File uploads#164
Merged
Merged
Conversation
3mcd
requested changes
Nov 14, 2023
Collaborator
3mcd
left a comment
There was a problem hiding this comment.
I still need to test and provide feedback for the Zod and CSS import issues, but I went ahead and left a little bit of early feedback.
Collaborator
There was a problem hiding this comment.
We could use the expect function from "utils" to have a bit more granular error reporting here, like:
const region = expect(process.env.ASSETS_REGION, "ASSETS_REGION environment variable missing")
// ...
Collaborator
There was a problem hiding this comment.
Some of our fields use snake-case e.g. "unjournal:evaluated-paper", so we should use that here or convert everything to camelCase. I have no strong feelings about either.
Collaborator
There was a problem hiding this comment.
A comment here explaining what fullFormats is doing would be helpful.
9c35b59 to
289d61c
Compare
289d61c to
063309a
Compare
063309a to
a14cd78
Compare
a14cd78 to
80509eb
Compare
3882213 to
e60ec1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Oops, forgot to create one.
--> Requires updating core's .env.local file with AWS bucket keys (in our 1Pass).
This adds a (poorly styled!) file uploader using Uppy, as well as some unjournal form enhancements.
There are two outstanding issues I need a little help tracking down:
Anyway, otherwise it works??
Test Plan
pubpub:fileUploadformField value with an array of files including public S3 links!Screenshots (if applicable)
Optional
Notes/Context/Gotchas
{pubId}/{fileName}key strategy, so that files are grouped by Pub. This might be a good strategy, but it also might not, because we might ultimately want to create a gallery that reuses assets across pubs? Idk. I don't think it's super important right now, but something to think on a little.Supporting Docs