tr: Membership spike#19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the schema to support members.
In doing so, it also experiments with the idea that we don't need workflows as a wrapper around stages. This comes both from the added complexity of ignoring or adding Workflow members, and feedback from a few demo calls. Based on those conversations with prospective users - the notion of distinct "workflows" doesn't seem obviously necessary and at times even problematic. A flat list of Stages seems to suffice (even if the graph if stages and possible transitions has disconnected subgraphs that in effect constitute a distinct 'workflow').
The benefits of this approach that I see at the moment are:
Register DOIstage every single time you want to try out a new peer review step. Stage graphs don't have to be fully disconnected and redundant.A few other thoughts about this approach:
workflowName/, and we could visually group stages with same prefix.