Skip to content

Basic UI for stages#192

Merged
qweliant merged 11 commits into
mainfrom
qdt/make-stage
Dec 4, 2023
Merged

Basic UI for stages#192
qweliant merged 11 commits into
mainfrom
qdt/make-stage

Conversation

@qweliant
Copy link
Copy Markdown
Contributor

@qweliant qweliant commented Nov 28, 2023

Issue(s) Resolved

Solves part of #190

Test Plan

This is the basic UI for editing stages.

Screenshots (if applicable)

Screencast.from.11-28-2023.03.10.53.PM.webm

Optional

Notes/Context/Gotchas

This isnt wired up. Its just the UI portion

Supporting Docs

@qweliant qweliant changed the title [DRAFT] basic CRUD for stages Basic CRUD for stages Nov 28, 2023
Copy link
Copy Markdown
Contributor

@kalilsn kalilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few issues but this looks like a great start!

Other than what I mentioned in the comments, it looks like the Moves to and Moves from sections aren't quite working in the edit form (or I don't understand them at least). The Moves to section renders unusable checkboxes, and Moves to seems to render links to the other tabs. Are either/both of these sections intended to be editable?

Comment thread core/app/c/[communitySlug]/stages/dashboard/StagesEditor.tsx Outdated
Comment thread core/app/c/[communitySlug]/stages/page.tsx Outdated
Comment thread core/app/c/[communitySlug]/stages/dashboard/stage.tsx Outdated
@qweliant
Copy link
Copy Markdown
Contributor Author

A few issues but this looks like a great start!

Other than what I mentioned in the comments, it looks like the Moves to and Moves from sections aren't quite working in the edit form (or I don't understand them at least). The Moves to section renders unusable checkboxes, and Moves to seems to render links to the other tabs. Are either/both of these sections intended to be editable?

nope. they should not work rn. this is just the UI

Copy link
Copy Markdown
Contributor

@kalilsn kalilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't totally understand why the moves to and moves from sections are different but this looks good! I'll evaluate that once the form is fully wired up

Comment thread core/app/c/[communitySlug]/stages/dashboard/StagesEditor.tsx Outdated
Comment thread core/app/c/[communitySlug]/stages/dashboard/stage.tsx Outdated
Comment thread core/app/c/[communitySlug]/stages/dashboard/StagesEditor.tsx Outdated
Comment thread core/app/c/[communitySlug]/stages/dashboard/StagesEditor.tsx Outdated
Comment thread core/app/c/[communitySlug]/stages/dashboard/stage.tsx Outdated
@qweliant
Copy link
Copy Markdown
Contributor Author

qweliant commented Nov 29, 2023

I still don't totally understand why the moves to and moves from sections are different but this looks good! I'll evaluate that once the form is fully wired up

i should have a list of all stages under moves to for each stage. the user will be able to define what stages they can move to.

for the moves from, as we have it coded now, they are inferred by the move constraint sources.

https://github.com/pubpub/v7/blob/df1f01bd24068ac4bcc9c2755e4cd13698f4a19c/core/app/c/%5BcommunitySlug%5D/stages/components/StageList.tsx#L19-L21

since the moves from are inferred, i render them as a list here to show what stages a stage can move back from. i'm not sure the list of moves from are necessary as is. i think some validation of the constraint and how it effects other stages is visually important though.

@qweliant qweliant changed the title Basic CRUD for stages Basic UI for stages Nov 30, 2023
@qweliant qweliant requested a review from 3mcd December 4, 2023 15:38
@qweliant qweliant merged commit 542e6f6 into main Dec 4, 2023
@qweliant qweliant deleted the qdt/make-stage branch December 4, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants