Skip to content

Fix zod installation in package.json#206

Merged
kalilsn merged 1 commit into
mainfrom
kalilsn/zod-install
Jan 23, 2024
Merged

Fix zod installation in package.json#206
kalilsn merged 1 commit into
mainfrom
kalilsn/zod-install

Conversation

@kalilsn
Copy link
Copy Markdown
Contributor

@kalilsn kalilsn commented Jan 23, 2024

Issue(s) Resolved

Builds have been failing because zod wasn't found:

core:build: Failed to compile.
core:build:
core:build: ./app/c/[communitySlug]/stages/dashboard/StagesEditor.tsx:20:20
core:build: Type error: Cannot find module 'zod' or its corresponding type declarations.
core:build:
core:build:   18 | 	TabsTrigger,
core:build:   19 | } from "ui";
core:build: > 20 | import * as z from "zod";
core:build:      |                    ^
core:build:   21 | import { stageSources } from "~/lib/pubStages";
core:build:   22 | import { StageIndex, StagePayload } from "~/lib/types";
core:build:   23 |
core:build:  ELIFECYCLE  Command failed with exit code 1.

@kalilsn kalilsn requested review from 3mcd, qweliant and ships January 23, 2024 18:07
Copy link
Copy Markdown
Collaborator

@ships ships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it, and did fix my local & docker build

, am curious what the purpose of original statement was & if there are downsides to this change?

@kalilsn
Copy link
Copy Markdown
Contributor Author

kalilsn commented Jan 23, 2024

as far as I understand it was a mistake! likely inserted by pnpm but we're not sure how!

@kalilsn kalilsn merged commit 9c3e430 into main Jan 23, 2024
@kalilsn kalilsn deleted the kalilsn/zod-install branch January 23, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants