Bootstrap AWS infrastructure#216
Merged
Merged
Conversation
b9d5d0e to
b19fd08
Compare
kalilsn
approved these changes
Feb 12, 2024
Contributor
kalilsn
left a comment
There was a problem hiding this comment.
Sorry for the slow review. This looks like a great base to build on, and I think you captured all my feedback in your TODOs anyways. Since these are all additive changes (with the exception of the permission fix on our build script), I think it's fine to address those in future PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: WIP.
Issue(s) Resolved
This PR introduces Terraform and Github Actions as declarative infrastructure and change management stack.
Test Plan
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
TODOS:
.tfvarsand.tfbackendSupporting Docs