Fix Deadline on Evaluator#221
Merged
Merged
Conversation
3mcd
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
#220
Test Plan
IntegrationInstanceStateScreenshots (if applicable)
Not using optional
Screen.Recording.2024-02-12.at.4.50.46.PM.mov
Using optional and coerce
Screen.Recording.2024-02-12.at.5.03.17.PM.mov
Optional
Notes/Context/Gotchas
The error eric mentioned in the issue is thrown with optional but without coerce.
this is the correct error without optional but with coerce
Supporting Docs