Add new emails#225
Merged
Merged
Conversation
3mcd
requested changes
Feb 28, 2024
added 10 commits
March 4, 2024 13:39
qweliant
force-pushed
the
qdt/eval-email-scheduling
branch
from
7e45bfb to
bfacd41
Compare
3mcd
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
#209
Test Plan
Change
runAtdate in email tonew Date(Date.now())Verify you receive all emals
Verify the email have the appropriate text(linked in issue)
Verify that the dates mentioned in the email are correct
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
Supporting Docs