add files directive to next-based packages#227
Merged
Conversation
3mcd
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Allows successful use of
pnpm deployof packages built withpreconstruct/next.Test Plan
Tested locally, built & deployed to AWS to verify.
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
pnpm deploysends all files (including .next AND all source files) to the "output" directory unlessfilesis present. Since that includesnext.config.js,npx next starttreats the environment as development and fails due to only having prod dependencies.Once
next buildhas been completed, we can ship with ONLY the.nextdirectory (for now).Some maintenance might be required here if more files are needed later, but it should be O(ln) in changes over time.
Supporting Docs