Suggest User#31
Merged
Merged
Conversation
…ing using something like express slow down
isTravis
temporarily deployed
to
qdt/suggested-user - core PR #31
Render
Destroyed
qweliant
commented
Aug 16, 2023
| return ( | ||
| <div | ||
| key={button.actions[0].text} | ||
| key={button.actions ? button.actions[0].text : "action"} |
Contributor
Author
There was a problem hiding this comment.
I was getting a type error that said button actions may be undefined when running pnpm build. Im not sure if this fix is required or not but it resolved the err i was getting
qweliant
commented
Aug 16, 2023
|
|
||
| const PubFieldsSchema = z.any(); | ||
|
|
||
| export type PubFieldsResponse = z.infer<typeof PubFieldsSchema>; |
Contributor
Author
There was a problem hiding this comment.
we are not using this type so ive removed it
Contributor
Author
|
i have removed every unimplemented |
qweliant
commented
Aug 21, 2023
3mcd
requested changes
Aug 21, 2023
| import prisma from "~/prisma/db"; | ||
| import { SuggestedMember } from "~/lib/contracts/resources/autosuggest"; | ||
|
|
||
| const getMembers = async (input: string): Promise<SuggestedMember[]> => { |
Collaborator
There was a problem hiding this comment.
Let's use a more descriptive variable name than input. Maybe namePart or partialName or something along those lines.
isTravis
temporarily deployed
to
qdt/suggested-user - core PR #31
Render
Destroyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds route implementation to autosuggest user and implements the pub contract using ts-rest
query pubs using:
http://localhost:3000/api/<:ntegrationId>/pub/<pubId>query autosuggested members using
http://localhost:3000/api/<integraionId>/autosuggest/<pubId>/members/<memberCandidateString>