Fetch pub values from evaluations integration#62
Merged
Conversation
3mcd
commented
Aug 31, 2023
Collaborator
Author
There was a problem hiding this comment.
Fixes a React warning that snuck in.
isTravis
temporarily deployed
to
em/fetch-pub-values - integration-evaluations PR #62
Render
Destroyed
3mcd
commented
Aug 31, 2023
Collaborator
Author
There was a problem hiding this comment.
@qweliant I wasn't able to get these routes working without the leading /.
3mcd
force-pushed
the
em/fetch-pub-values
branch
from
949469e to
c514cc6
Compare
isTravis
temporarily deployed
to
em/fetch-pub-values - core PR #62
Render
Destroyed
isTravis
temporarily deployed
to
em/fetch-pub-values - integration-evaluations PR #62
Render
Destroyed
3mcd
commented
Aug 31, 2023
Collaborator
Author
There was a problem hiding this comment.
Right now the client types all pub values as unknown so I just do an explicit conversion/cast here so TS doesn't yell at me.
3mcd
commented
Aug 31, 2023
Collaborator
Author
There was a problem hiding this comment.
Renamed put to patch since the verb changed in core.
3mcd
commented
Aug 31, 2023
Collaborator
Author
There was a problem hiding this comment.
Snuck this in as a contrived example of the SDK doing runtime validation of pub fields.
3mcd
requested review from
kalilsn and
qweliant
and removed request for
kalilsn
3mcd
force-pushed
the
em/fetch-pub-values
branch
from
c514cc6 to
70f96b4
Compare
isTravis
temporarily deployed
to
em/fetch-pub-values - core PR #62
Render
Destroyed
isTravis
temporarily deployed
to
em/fetch-pub-values - integration-evaluations PR #62
Render
Destroyed
3mcd
commented
Aug 31, 2023
| "title": { | ||
| "id": "aa63cab5-3729-4a12-813b-eae316eceb69" | ||
| } | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
This still doesn't do much, just a placeholder manifest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick PR that uses the new core API route structure to fetch Pub fields in the evaluations integration.