Hardcode some ids for unjournal#64
Merged
Merged
Conversation
isTravis
temporarily deployed
to
kalilsn/hardcode-ids - core PR #64
Render
Destroyed
isTravis
temporarily deployed
to
kalilsn/hardcode-ids - integration-evaluations PR #64
Render
Destroyed
kalilsn
force-pushed
the
kalilsn/hardcode-ids
branch
from
55c0f1c to
de905ce
Compare
isTravis
temporarily deployed
to
kalilsn/hardcode-ids - core PR #64
Render
Destroyed
isTravis
temporarily deployed
to
kalilsn/hardcode-ids - integration-evaluations PR #64
Render
Destroyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcodes some uuids for integration instances and pub types since we have to use those to construct URLs during testing.
If this still feels too cumbersome, we can make some test data with shorter strings as ids (not actually UUIDs)
@3mcd @qweliant