Add read/write pub endpoints#9
Merged
Merged
Conversation
3mcd
requested changes
Jul 19, 2023
Collaborator
3mcd
left a comment
3mcd
left a comment
There was a problem hiding this comment.
A few (extremely) small items, but otherwise looks (and works) excellent!
Collaborator
There was a problem hiding this comment.
More of a question because I don't know Prisma at all, but is it necessary to include the values you intend to update when calling update?
Contributor
Author
There was a problem hiding this comment.
i don't believe you do, but the docs weren't entirely clear!
|
Your Render PR Server URL is https://pubpub-core-v7-prod-pr-9.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cj99cvicn0vc73afms2g. |
Pluralize integrations and update auth strategy
kalilsn
force-pushed
the
kalilsn/read-write-pubs
branch
from
ba9ab23 to
9ad3950
Compare
Contributor
Author
|
@3mcd merging this so Qwelian has it in his branch, but we can keep refining later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds very minimal working read/write endpoints for a pub. The structure of the requests and responses will change but you should be able to test integrations with this for now.
For now, to update fields, pass them in the JSON body of the put request under the
fieldskey:{"fields": {"fieldName1": "some value", "fieldname2": "another value"}}cc @howebenhowe @qweliant @isTravis @gabestein