Permissions #92
Merged
Merged
Conversation
isTravis
temporarily deployed
to
qdt/permissions - integration-evaluations PR #92
Render
Destroyed
qweliant
force-pushed
the
qdt/permissions
branch
from
68d78bc to
4c62024
Compare
isTravis
temporarily deployed
to
qdt/permissions - core PR #92
Render
Destroyed
isTravis
temporarily deployed
to
qdt/permissions - integration-submissions PR #92
Render
Destroyed
isTravis
temporarily deployed
to
qdt/permissions - core PR #92
Render
Destroyed
isTravis
temporarily deployed
to
qdt/permissions - integration-submissions PR #92
Render
Destroyed
added 2 commits
September 18, 2023 15:41
stole erics version of this
3mcd
requested changes
Sep 19, 2023
Collaborator
3mcd
left a comment
3mcd
left a comment
There was a problem hiding this comment.
Just a few more tweaks and this will be good to go
isTravis
temporarily deployed
to
qdt/permissions - integration-submissions PR #92
Render
Destroyed
isTravis
temporarily deployed
to
qdt/permissions - core PR #92
Render
Destroyed
isTravis
temporarily deployed
to
qdt/permissions - integration-submissions PR #92
Render
Destroyed
qweliant
commented
Sep 19, 2023
| } else { | ||
| throw new Error("Invalid permission"); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
just gets the permissions for each stage
qweliant
commented
Sep 19, 2023
Contributor
Author
There was a problem hiding this comment.
i split out pub row
qweliant
commented
Sep 19, 2023
Contributor
Author
There was a problem hiding this comment.
split out integration button actions
qweliant
commented
Sep 19, 2023
Comment on lines
+24
to
+31
| <Move pub={props.pub} stage={props.stage} stages={props.stages} /> | ||
| <Assign | ||
| pub={props.pub} | ||
| loginData={props.loginData} | ||
| stage={props.stage} | ||
| stages={props.stages} | ||
| users={props.users} | ||
| /> |
Contributor
Author
There was a problem hiding this comment.
split out these actions into two buttons
qweliant
commented
Sep 19, 2023
Comment on lines
+16
to
+17
| const users = getPubUsers(stage.permissions); | ||
| const destinations = stage.moveConstraints.map((stage) => stage.destination); |
Contributor
Author
There was a problem hiding this comment.
gets users that can act on stages and stages that can be moved to
3mcd
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Resolves #87
Resolves #85
Resolves #86
Test Plan
Visit stages. Be sure they can only move to places that are listed in the seed file.
Reference the seed file to check constraints for user claims as well.
Not Jill though. Jill can do everything
Screenshots (if applicable)
Screencast.from.09-18-2023.04.54.44.PM.webm
Screencast.from.09-18-2023.04.58.23.PM.webm
Optional
Notes/Context/Gotchas
I used two patterns listed in nextjs docs on routing and project structure. Shared components between routes live in the root of core in components. components used exclusively in routes live in components.
Supporting Docs