fix: edge case where pubs with sibling edges of different domains would 500#2948
fix: edge case where pubs with sibling edges of different domains would 500#2948
Conversation
…revent weird connection 500 edge case
…een proven to work
There was a problem hiding this comment.
Found a small issue here that prevents merging, unfortunately. On custom domain pages with any connections at all, it will set the surrogate-key to the community subdomain rather than the hostname, which will prevent purging of any custom domain pages with surrogate keys.
E.g., on https://duqduqdomaintest.underlay.org/pub/zkme9ef3/release/9, surrogate-key is gabestein.duqduq.org rather than duqduqdomaintest.underlay.org
|
Hmm i think this should work, I reverted this problem from the previous commit. AFAIK the one on duqduq is the previous one right? |
|
Ah, yes, you're right, this isn't on duqduq yet. Sorry, I'll revert my commit. |
| [getCorrectHostname(subdomain, domain)] as string[], | ||
| [req.hostname] as string[], |
There was a problem hiding this comment.
i mean this change here: above is how it is on duqduq, below is how it is on prod
Issue(s) Resolved
Test Plan
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
Supporting Docs