Skip to content

fix: some follow up fixes for userspam management#3517

Merged
tefkah merged 13 commits intomainfrom
tfk/better-fixes
Mar 4, 2026
Merged

fix: some follow up fixes for userspam management#3517
tefkah merged 13 commits intomainfrom
tfk/better-fixes

Conversation

@tefkah
Copy link
Member

@tefkah tefkah commented Mar 4, 2026

Issue(s) Resolved

  • fix: improve superadmin ui
    • Properly refresh spam status on click
  • fix: dev infra
    • Merged without looking! Removed double properties
  • fix: don't double notify
    • We kept getting two notifs for the creation of the spamtag, and that the user was banned. bit too much
  • fix: add no store header to be safe
    • I'm paranoid this may end up being cached by fastly
  • fix: more regocnizable spamstatus
    • Shield instead of flag, in prep for CommunityAdmin flagging
  • fix: also make website honeypot
    • Don't allow users to set their website upon signup. Add a new "website" honeypot input instead. Should cut down on even more spam.
  • fix: allow filtering by amount of activity
    • Makes it easier to ban problematic users
  • refactor: better notification setup
    • Refactored the notifications into a separate system, was getting too hairy trying to do it inline when updating spamtags. also updated the spamtag updating logic, it was too convoluted (classic case of "trying to make things simpler by grouping it into a function but then needing to modify that big function slightly and oops now you have three big functions that you need to call all the time lmao")

Test Plan

Screenshots (if applicable)

Optional

Notes/Context/Gotchas

Supporting Docs

@tefkah
Copy link
Member Author

tefkah commented Mar 4, 2026

I will just merge this, as it doesn't really change any of the logic, just a lil polish!

@tefkah tefkah merged commit 932600b into main Mar 4, 2026
1 of 2 checks passed
@tefkah tefkah deleted the tfk/better-fixes branch March 4, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant