Skip to content

feat: point to kf auth to manage email/password#3623

Merged
tefkah merged 2 commits into
mainfrom
tfk/rework-settings
May 27, 2026
Merged

feat: point to kf auth to manage email/password#3623
tefkah merged 2 commits into
mainfrom
tfk/rework-settings

Conversation

@tefkah
Copy link
Copy Markdown
Member

@tefkah tefkah commented May 27, 2026

Issue(s) Resolved

Remove ability to change email and password etc.

Test Plan

Screenshots (if applicable)

Optional

Notes/Context/Gotchas

Supporting Docs

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes PubPub’s legacy email/password change functionality and updates the settings UI to direct users to manage those credentials in the Knowledge Futures (KF) Account app, aligning account security management with the new OIDC/KF auth flow.

Changes:

  • Removed /api/account/password and /api/account/email contract + server implementations (and associated tests/email helper).
  • Added OIDC_ACCOUNT_URL configuration and wired it through the Legal/Privacy Settings page.
  • Replaced the in-app “Account security” forms with a link to KF Account management, and removed the legacy EmailChange page/route.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
utils/api/contracts/account.ts Removes email/password change endpoints from the account API contract.
server/utils/email/reset.ts Removes the email-change email sender helper.
server/user/account.ts Removes server handlers for changing password/email; keeps deletion/export endpoints.
server/user/tests/password.test.ts Deletes tests that covered the removed password-change endpoint.
server/user/tests/email.test.ts Deletes tests that covered the removed email-change endpoints.
server/routes/legal.tsx Passes accountUrl into view data for the settings UI.
server/kf/oidc.server.ts Introduces OIDC_ACCOUNT_URL env-backed constant and exports it.
server/kf/auth.ts Re-exports OIDC_ACCOUNT_URL via the shim.
client/containers/Legal/PrivacySettings.tsx Threads accountUrl through to AccountSecuritySettings.
client/containers/Legal/Legal.tsx Adds accountUrl prop and passes it down to settings.
client/containers/Legal/DeleteAccount.tsx Adjusts deletion-audit messaging markup (warning block wrapper changed).
client/containers/index.ts Removes EmailChange export.
client/containers/EmailChange/index.ts Deletes legacy EmailChange container entrypoint.
client/containers/EmailChange/EmailChange.tsx Deletes legacy EmailChange page implementation.
client/containers/EmailChange/emailChange.scss Deletes legacy EmailChange styling.
client/containers/App/paths.ts Removes EmailChange route mapping from app paths.
client/components/AccountSecuritySettings/AccountSecuritySettings.tsx Replaces forms with a KF Account management link/button.
client/components/AccountSecuritySettings/accountSecuritySettings.scss Deletes unused styling for the removed forms.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 24 to 29
type Props = {
integrations: Integration[];
userNotificationPreferences?: UserNotificationPreferences;
userEmail: string;
accountUrl: string;
accountExports?: {
Comment on lines 74 to 78
{isLoadingAudit && <Spinner size={20} />}
{audit && audit.soleAdminCommunities.length > 0 && (
<Callout intent="warning" style={{ marginBottom: 15 }}>
<>
<p>
You cannot delete your account because you are the only admin of{' '}
@tefkah tefkah merged commit 0d15fa8 into main May 27, 2026
2 checks passed
@tefkah tefkah deleted the tfk/rework-settings branch May 27, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants