Skip to content

Refactor HTML pages using Wicket markup inheritance#382

Merged
ashleycaselli merged 8 commits intomasterfrom
refactor/wicket-html
Mar 11, 2026
Merged

Refactor HTML pages using Wicket markup inheritance#382
ashleycaselli merged 8 commits intomasterfrom
refactor/wicket-html

Conversation

@ashleycaselli
Copy link
Member

This pull request refactors several HTML page templates in the src/main/java/com/knowledgepixels/nanodash/page/ directory to modernize their structure for Apache Wicket. The changes primarily replace legacy HTML layout with Wicket's <wicket:head> and <wicket:extend> tags, streamline markup, and improve maintainability. Additionally, the ApplicationsDemoPage.html updates link references to point to local files for demonstration purposes.

Template modernization and Wicket integration:

  • Replaced <head> and <body> sections with Wicket's <wicket:head> and <wicket:extend> tags in ChannelPage.html, ErrorPage.html, ExplorePage.html, GroupDemoPage.html, and ApplicationsDemoPage.html for consistent component-based layout. [1] [2] [3] [4] [5]
  • Removed redundant elements such as <meta charset>, stylesheet links, favicon, and manual titlebars, as these are now handled by Wicket components. [1] [2] [3] [4] [5]

Content and markup improvements:

  • Reformatted lists and paragraphs for improved readability and maintainability, including breaking long lines and adding indentation in GroupDemoPage.html and ApplicationsDemoPage.html. [1] [2] [3] [4]
  • Fixed closing tags and removed unnecessary container divs, ensuring correct Wicket component structure and valid HTML. [1] [2] [3]

These changes make the templates more modular, easier to maintain, and better suited for Wicket-based web applications.

@tkuhn
Copy link
Contributor

tkuhn commented Mar 9, 2026

Nice!

Small thing: These lines

<link rel="stylesheet" href="../../../../../webapp/style.css?for-local-testing-only" type="text/css" media="screen" title="Stylesheet" />

were there so the pages can be viewed locally and statically in a browser. Any easy way we can keep that?

Will do a proper check of the entire PR as well...

@ashleycaselli
Copy link
Member Author

Nice!

Small thing: These lines

<link rel="stylesheet" href="../../../../../webapp/style.css?for-local-testing-only" type="text/css" media="screen" title="Stylesheet" />

were there so the pages can be viewed locally and statically in a browser. Any easy way we can keep that?

Will do a proper check of the entire PR as well...

I think just adding that line in the <head> section of the NanodashPage would do the trick. I will test that tomorrow.

@tkuhn
Copy link
Contributor

tkuhn commented Mar 11, 2026

Small glitch now in the GUI (left of agent dropdown):

image

@ashleycaselli
Copy link
Member Author

Small glitch now in the GUI (left of agent dropdown):

image

This is fixed in c90d867.

@ashleycaselli ashleycaselli merged commit 808af3f into master Mar 11, 2026
3 of 4 checks passed
@ashleycaselli ashleycaselli deleted the refactor/wicket-html branch March 11, 2026 10:09
@github-actions
Copy link

🎉 This PR is included in version 4.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants