Bump nanopub to 1.90.0 and drop placeholder/expansion code it now provides#471
Merged
Conversation
…it now provides nanopub 1.90.0 adds _multi_val placeholder support to QueryTemplate, which was the only reason nanodash carried its own copies of the grlc placeholder conventions and query expansion. With the bump these become redundant: - QueryParamField: remove the duplicated static isMultiPlaceholder/isOptional/ getParamName; instance methods and expandValues now delegate to QueryTemplate. - GrlcQuery.expandQuery: reduce to a thin adapter that maps the UI param fields into QueryTemplate.expandQuery(params, false) (strict=false gives the lenient partial expansion used for the Yasgui link); drop the duplicated substitution/ serialization loop and escapeSlashes helper. - ViewList, DownloadRdfPage, LookupApis: call QueryTemplate.* directly. Behavior note: an unfilled multi-value placeholder now has its empty VALUES block removed (library behavior) rather than left in place, yielding a runnable Yasgui link. mvn test: 691 run, 0 failures. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nanopub
1.90.0adds_multi_valplaceholder support (and astrictflag) toQueryTemplate— the only reason nanodash still carried its own copies of the grlc placeholder conventions and query expansion. With the bump those become redundant.Changes
pom.xml— nanopub1.89.0→1.90.0.QueryParamField— removed the duplicated staticisMultiPlaceholder/isOptional/getParamName(now identical toQueryTemplate's, including the_multi_valsupport nanodash had added locally). Instance methods andexpandValuesdelegate toQueryTemplate.GrlcQuery.expandQuery— reduced to a thin adapter that maps the UIQueryParamFields intoQueryTemplate.expandQuery(params, false).strict=falseprovides the lenient partial expansion used for the Yasgui link. Dropped the duplicated substitution/serialization loop andescapeSlashes.ViewList,DownloadRdfPage,LookupApis— callQueryTemplate.*directly (isOptional→isOptionalPlaceholder); unusedQueryParamFieldimports removed.Net: −81 / +27 across 6 files; the
_multi_valconvention now lives in exactly one place (nanopub-java).Behavior note
For an unfilled multi-value placeholder, the Yasgui-link query now has its empty
VALUES ?x {}block removed (library behavior) instead of left in place — a runnable, unconstrained query rather than one returning nothing. Theauto_execution_blockerguard for unfilled mandatory fields is unchanged.Verification
mvn compileclean on 1.90.0.mvn test: 691 run, 0 failures, 0 errors (incl.GrlcQueryTest).🤖 Generated with Claude Code