Show all templates on Publish page as a single sortable table#472
Merged
Conversation
Replaces the topic-grouped "All Templates" section on the Publish page with a single view driven by the published get-all-templates query, rendered as a sortable table (template · tag · creator · date) via QueryResultTableBuilder. This reuses the existing all-templates-view (a TabularView), so the renderer now matches the view's declared type, and adds server-side data + a filter box in place of the client-side per-tag grouping (DataView<Topic>/ItemListPanel). Also strip a trailing _iri suffix when deriving tabular column headers, so the header reads "template" instead of "template iri" (and "user" instead of "user iri", etc.) — completing the pattern already applied to _multi/_multi_iri/ _multi_val. The full column key is unchanged, so the template_iri publish-link special-casing, label pairing and sorting all still work. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the topic-grouped All Templates section on the Publish page with a single, sortable table of all templates.
Changes
TemplateList— the per-tag grouping (DataView<Topic>+ItemListPanel+ client-sideTemplateDatasort) is replaced by one view over the publishedget-all-templatesquery, rendered withQueryResultTableBuilder. This reuses the existingall-templates-view(aTabularView), so the renderer now matches the view's declared type. Columns: template (clickable → publish form) · tag · creator · date, each with a sortable header, plus the built-in filter box and pagination. (TemplateList.htmlsimplified to a singleall-templatescontainer; the redundant<h3>dropped since the view supplies its title.)QueryResultTable— strip a trailing_iriwhen deriving column headers, so headers read "template"/"user" instead of "template iri"/"user iri". Completes the pattern already applied to_multi/_multi_iri/_multi_val; the full column key is untouched, so the publish-link special-casing, label pairing, and sorting are unaffected.Notes
_labelcompanion (template sorts by name).?creator/signer), and the date shows as a raw ISO string (sorts chronologically). Prettifying those (author name, formatted date) would require editing + republishing theget-all-templatesquery.Verification
mvn compileclean; wicket:ids match;WicketApplicationTestgreen. No automated PublishPage render test exists, so the page itself wasn't machine-rendered.🤖 Generated with Claude Code