feat: expose Nanopub-Query-Loaded-Nanopub-Count response header#100
Merged
Conversation
Reports the cumulative count of nanopubs ever loaded into the `full` repo, complementing the existing `Nanopub-Query-Registry-Nanopub-Count` passthrough so clients can distinguish "what's loaded here" from "what the registry has". Matches the registry-side semantics (invalidations don't decrement). Sourced from the existing `npa:hasNanopubCount` admin triple — no new persistent state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nanopub-Query-Loaded-Nanopub-Countreporting the cumulative count of nanopubs ever loaded into thefullrepo.Nanopub-Query-Registry-Nanopub-Countpassthrough, which describes the upstream registry's view — together they let clients distinguish "what this instance has loaded" from "what the registry has", which is particularly useful inLOADING_INITIALto gauge ingestion progress.npx:invalidatesmarkers and don't touch the count).npa:hasNanopubCountadmin triple thatNanopubLoader.loadNanopubToRepoalready maintains. The Java-sideloadedNanopubCountis a process-local cache: lazily initialised from the store on first read, bumped post-commit on each fresh load to thefullrepo.Test plan
MainVerticleGlobalHeadersTest.emitsLoadedNanopubCountWhenPresentcovers the new header (mirrors the existingforwardsNanopubCountWhenPresent)Tests run: 215, Failures: 0, Errors: 0🤖 Generated with Claude Code