Skip to content

Fix XYChart area fill for negative values #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2019
Merged

Fix XYChart area fill for negative values #327

merged 1 commit into from
Jun 18, 2019

Conversation

@konstiv23
Copy link

@konstiv23 konstiv23 commented Jun 16, 2019 •
edited
Loading

Closes #326
Previously filled between values and bottom of the chart, not values and 0.

@gitkonst
Fix XYChart area fill for negative values
3b8b481 
Closes knowm#123
knowm#326
Previously filled between vallues and bottom of the chart, not values and 0.
@konstiv23 konstiv23 mentioned this pull request Jun 17, 2019
Closed
@timmolter timmolter merged commit 539ad5d into knowm:develop Jun 18, 2019
@timmolter
Copy link
Member

timmolter commented Jun 18, 2019

This PR broke normal chart rendering. Please submit a fix including a sample chart like others found in the standalone/issues package.

Screen Shot 2019-06-18 at 14 30 32

@timmolter
Copy link
Member

timmolter commented Jun 18, 2019

Or add a AreaChart05 to the XChart Demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Area chart should fill negative values from zero

3 participants

@konstiv23 @timmolter @gitkonst