Fix #686: truncate long legend series names with ellipsis#945
Merged
Conversation
A series name longer than 45% of the chart width caused the legend to overflow, leaving no room for the plot area. getSeriesTextBounds() now caps each line at MAX_LEGEND_TEXT_WIDTH_RATIO (0.45) of the chart width and appends "…" when truncation is needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a series name is very long, the legend width grows to exceed the chart width, pushing the plot area to zero (or negative) width. The chart content disappears entirely — both in the Swing display and in exported bitmaps.
Fix
In
Legend_.java,getSeriesTextBounds()now computes a max text width of 45% of the chart width. If a label line exceeds that, a newtruncateLabel()helper trims characters from the right and appends…until it fits.Demo
TestForIssue686.javainstandalone/issues/shows a series with a very long name rendered correctly with a truncated legend entry.Fixes #686