Close #779: add demo verifying bar labels visible with custom fill color#946
Merged
Conversation
Bar tip labels are correctly visible when setFillColor() is used. Adding a demo class to document the verified behaviour. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
All label positions remain visible with custom fill colors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #779 reported that bar tip labels become invisible when
setFillColor()is called on a series. This has since been fixed (the automatic label font contrast logic now correctly handles custom fill colors).This PR adds
TestForIssue779.javato document and preserve the verified behaviour with a side-by-side demo of two charts — one with and one without a custom fill color — both showing visible labels.Closes #779