Skip to content

fix(references): bound doc ref parsing#117

Merged
howznguyen merged 1 commit into
knowns-dev:developfrom
HarryVu176:broken_doc_ref_fix
Jun 4, 2026
Merged

fix(references): bound doc ref parsing#117
howznguyen merged 1 commit into
knowns-dev:developfrom
HarryVu176:broken_doc_ref_fix

Conversation

@HarryVu176
Copy link
Copy Markdown
Contributor

Description

  • Replaced greedy doc reference matching with bounded extraction in internal/references
  • Prevents Markdown/prose delimiters from being included in parsed @doc/ paths
  • Preserves supported suffixes like :42, :10-25, #heading, and {relation}
  • Skips fenced code blocks during reference extraction

Related Issue

Fixes #116

Type of Change

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Other (please describe):

Checklist

  • [ x ] My code follows the project's style guidelines
  • [ x ] I have performed a self-review of my code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] My changes generate no new warnings
  • [ x ] I have added tests that prove my fix is effective or that my feature works
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] Any dependent changes have been merged and published

- Prevent Markdown/prose delimiters from being parsed as doc paths.
@welcome
Copy link
Copy Markdown

welcome Bot commented Jun 4, 2026

Thanks for opening this pull request! 🎉

Please make sure:

  • Your code follows our coding conventions
  • You've added tests for your changes (if applicable)
  • You've updated the documentation (if applicable)
  • All CI checks pass

A maintainer will review your PR soon. Thanks for contributing to Knowns CLI!

@howznguyen howznguyen merged commit 1add053 into knowns-dev:develop Jun 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants