Set 'Retry-After' header when throwing error#63
Merged
titanism merged 1 commit intokoajs:masterfrom Dec 6, 2023
Merged
Conversation
This change sets the 'Retry-After' response header when throwing the 429 error (i.e. the `throw` option is set to `true`). Previously this was not the case because Koa's default error handler unsets all response headers before setting those specified in the error object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change sets the 'Retry-After' response header when throwing the 429 error (i.e. the
throwoption is set totrue). Previously this was not the case because Koa's default error handler unsets all response headers before setting those specified in the error object.I had to change the error handling in the tests because catching and handling the error bypassed Koa's error handler.
Please let me know if you have questions or suggestions