feat(validator): add all constrait validator#180
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new built-in all constraint to apply nested validation rules to each element of an array, and updates violation flattening so nested/indexed violation paths can be represented in a dot-notation style for easier client consumption (e.g., form error mapping).
Changes:
- Introduces
allconstraint (with unit + integration tests) and registers/exports it via the constraints public API. - Updates
createValidatornested-rule plumbing to preserve the “current value” explicitly when descending into nested validations. - Extends
flattenViolationsto format bracketed/indexed paths (e.g.matrix[1][0]) into dot notation (matrix.1.0) and adds tests.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/validator/flatten-violations.ts |
Formats violation paths before grouping/flattening. |
src/validator/flatten-violations.test.ts |
Adds coverage for bracket/index path formatting cases. |
src/validator/factory/create-validator.ts |
Adjusts nested validation value passing to preserve explicit undefined values. |
src/validator/constraints/other/all.ts |
Adds the new all constraint implementation. |
src/validator/constraints/other/all.test.ts |
Unit tests for all constraint behavior. |
src/validator/constraints/other/all.integration.test.ts |
End-to-end validation tests for all in real schemas/groups/composition. |
src/validator/constraints/index.ts |
Registers all in builtInConstraints and exports it from the public constraints API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
allconstraint.flatten-violationhelper to support nested violation flattening and formating.