Skip to content

Convert string-typed enum fields to proper proto enums #192

@SebastienMelki

Description

@SebastienMelki

From PR #106 review — item M-10

Several request fields use bare strings where proper proto enums would be more appropriate:

  • GetPopulationExposureRequest.mode: accepts "countries" or "exposure"
  • SummarizeArticleRequest.mode: accepts "brief", "analysis", or "translate"
  • SearchGdeltDocumentsRequest.timespan: accepts "15min", "1h", "24h"

Problem: Bare strings provide no compile-time validation, no autocomplete, and no documentation of valid values. Clients have to guess or read handler source code.

Suggested fix: Define proper proto enum types for each and update handlers to accept enum values.


Deferred from PR #106 code review

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: APIBackend API, sidecar, keysrefactorCode restructuring, architecture

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions