-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Open
Labels
area: APIBackend API, sidecar, keysBackend API, sidecar, keysrefactorCode restructuring, architectureCode restructuring, architecture
Description
From PR #106 review — item M-10
Several request fields use bare strings where proper proto enums would be more appropriate:
GetPopulationExposureRequest.mode: accepts"countries"or"exposure"SummarizeArticleRequest.mode: accepts"brief","analysis", or"translate"SearchGdeltDocumentsRequest.timespan: accepts"15min","1h","24h"
Problem: Bare strings provide no compile-time validation, no autocomplete, and no documentation of valid values. Clients have to guess or read handler source code.
Suggested fix: Define proper proto enum types for each and update handlers to accept enum values.
Deferred from PR #106 code review
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area: APIBackend API, sidecar, keysBackend API, sidecar, keysrefactorCode restructuring, architectureCode restructuring, architecture