fix(resilience): revert overall score to domain-weighted average + fix RSF direction

[koala73]

Summary

• Overall score formula reverted from baseline*(1-stressFactor) to sum(domainScore * domainWeight). The multiplicative formula crushed all scores by 30-50% (Norway scored 60.7 instead of ~83, Germany 39.9 instead of ~68).
• RSF press freedom direction fixed: normalizeHigherBetter changed to normalizeLowerBetter since RSF uses 0=best, 100=worst. Norway's raw score of 6.52 was producing 7 instead of ~93.
• Seed script ranking write removed: the handler owns ranking generation with proper greyedOut split. Script becomes a read-only health check.
• Widget "Impact: -X%" row removed: stressFactor no longer drives the headline score.
• Cache keys bumped: score v6, ranking v6, history v3 (new formula = incomparable scores).

Test plan

• All 85 resilience tests pass (dimension scorers, scorers, release gate, handlers, ranking, seed, widget)
• TypeScript checks pass (both tsconfig.json and tsconfig.api.json)
• Pre-push hooks pass (typecheck, tests, lint, edge function isolation)
• Verify Norway overall >= 75 in production after deploy
• Verify Germany overall >= 60 in production after deploy
• Verify Western Sahara is greyed out (not in ranked items)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
worldmonitor	Ignored	Preview	Apr 9, 2026 4:46am

[greptile-apps]

Greptile Summary

This PR reverts the overall resilience score from a multiplicative baseline*(1-stressFactor) formula back to a domain-weighted average, fixes the RSF press-freedom direction (normalizeLowerBetter replaces normalizeHigherBetter), removes the ranking write from the seed script, strips the widget's "Impact" row, and bumps all cache keys to v6/v3 to invalidate stale data.

The formula revert and RSF direction fix are both correct: domain weights sum to exactly 1.0 (0.22+0.20+0.15+0.25+0.18), and RSF scores (0=best, 100=worst) now map as intended so Norway's raw score of 6.52 will produce ~93 rather than ~7.

Confidence Score: 5/5

Safe to merge — all changes are correct bug fixes with consistent cache-key versioning and full test coverage.

The two core fixes (RSF direction and overall score formula) are mathematically correct; domain weights verified to sum to 1.0; cache keys are bumped consistently across server, seed, and health check; the only remaining finding is a P2 orphaned export with no runtime impact.

No files require special attention; the orphaned RESILIENCE_RANKING_CACHE_TTL_SECONDS export in scripts/seed-resilience-scores.mjs is cosmetic only.

Vulnerabilities

No security concerns identified. The changes are formula corrections, cache key bumps, and UI cleanup with no auth, input validation, or data-exposure implications.

Important Files Changed

Filename	Overview
server/worldmonitor/resilience/v1/_shared.ts	Core fix: overall score reverted to domain-weighted average; stressFactor still computed and returned for API compatibility; cache keys bumped to v6/v3; weights sum to 1.0.
server/worldmonitor/resilience/v1/_dimension-scorers.ts	RSF press-freedom direction corrected: normalizeHigherBetter → normalizeLowerBetter(rsfScore, 0, 100), aligning with RSF's 0=best, 100=worst scale.
scripts/seed-resilience-scores.mjs	Seed script converted to read-only health check; ranking write and helper functions removed; cache prefix/key bumped to v6; RESILIENCE_RANKING_CACHE_TTL_SECONDS kept exported but no longer used inside the script.
src/components/ResilienceWidget.ts	Widget "Impact: -X%" row removed; baseline/stress display retained; no other functional changes.
api/health.js	Single cache key bump: resilience:ranking:v5 → resilience:ranking:v6; consistent with server-side and seed-script constants.
tests/resilience-scores-seed.test.mjs	Tests trimmed to assert v6 key constants and confirm ranking helpers are no longer exported; no logic under test is lost.
tests/resilience-handlers.test.mts	History key bumped to v3 in fixtures; handler test asserts score cache uses resilience:score:v6:US, consistent with the new constants.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Country Request] --> B[scoreAllDimensions]
    B --> C[buildDimensionList]
    C --> D["buildDomainList\ncoverage-weighted mean per domain"]
    D --> E["overallScore = sum of domain.score x domain.weight\neconomic 22% + infra 20% + energy 15%\nsocial-gov 25% + health-food 18%"]
    E --> F["classifyResilienceLevel\nhigh>=70 / medium>=40 / low"]
    F --> G["Cache: resilience:score:v6:iso2"]

    subgraph RSF_Fix ["RSF Direction Fix"]
      H["Raw RSF score 0=best 100=worst"]
      H --> I["normalizeLowerBetter(rsfScore, 0, 100)\nNorway 6.52 maps to ~93\nwas normalizeHigherBetter producing ~7"]
    end

    subgraph Ranking ["Ranking (Vercel handler)"]
      G --> J["Build greyedOut split\nwarm missing scores"]
      J --> K["Cache: resilience:ranking:v6"]
    end

    subgraph Seed ["Seed Script - read-only"]
      L["Railway cron every 5h"] --> M["Read static index"]
      M --> N["Count cached scores\nno Redis writes"]
    end

Loading

_{Reviews (1): Last reviewed commit: "fix(resilience): revert overall score to..." | Re-trigger Greptile}