fix(breaking-news): critical alerts bypass cooldown and replace HIGH alerts#516
fix(breaking-news): critical alerts bypass cooldown and replace HIGH alerts#516
Conversation
…place HIGH alerts Global cooldown (60s) was blocking critical alerts when a less important HIGH alert fired from an earlier RSS batch. Added priority-aware cooldown so critical alerts always break through. Banner now auto-dismisses HIGH alerts when a CRITICAL arrives. Added Iran/strikes keywords to classifier.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c51c4f742
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'air strikes': 'conflict', | ||
| 'drone strike': 'conflict', | ||
| 'drone strikes': 'conflict', | ||
| 'strikes': 'conflict', |
There was a problem hiding this comment.
strikes from high-severity keywords
Adding a standalone strikes keyword causes classifyByKeyword to label any headline containing that word as high (for example labor or diplomatic headlines like “workers plan strikes” or “country strikes a deal”), and those high labels are treated as breaking alerts downstream, producing noisy banner/notification false positives. This is an accuracy regression introduced by the commit; the keyword should be narrowed to military-specific phrases or contextualized with adjacent conflict terms.
Useful? React with 👍 / 👎.
1 participant
Summary
Test plan
tsc --noEmitpasses (confirmed locally)