fix(aviation): replace broken lock with direct cache + cancellation tiers#591
Merged
fix(aviation): replace broken lock with direct cache + cancellation tiers#591
Conversation
…ancellation tiers The Redis SETNX lock for AviationStack had a 3s wait but the API takes ~25s for 50 airports. Every lock-loser fell back to simulation — meaning AviationStack data was never served despite the API key being configured. Changes: - Remove fetchIntlWithLock/tryAcquireLock, use getCachedJson/setCachedJson with conditional TTL (30min real data, 5min simulation fallback) - Add cancellation severity tiers: ≥20% moderate, ≥10% minor (DXB at 32% cancelled was previously dropped as null) - Bump cache key to v2 to invalidate stale simulation data - Add HTML content-type detection for NOTAM API (ICAO CloudFront returns HTML challenge pages from Vercel datacenter IPs)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchIntlWithLock/tryAcquireLockwith directgetCachedJson/setCachedJsonand conditional TTL (30min real, 5min simulation)Verified with live API
Test plan
npx tsc --noEmitpasses[Aviation] AviationStack OK:instead offalling back to simulationSupersedes #589