fix(aviation): prevent AviationStack API quota blowout#623
Merged
Conversation
- Replace manual getCachedJson/setCachedJson with cachedFetchJson for intl delays — prevents thundering herd (concurrent misses each firing 93 API calls independently) - Bump Redis cache TTL from 30min to 2h - Bump frontend polling from 10min to 2h to match server cache - Bump circuit breaker browser cache from 5min to 2h - Bump CDN edge tier from medium (5min) to static (1h) - Bump cache key to v3 to force fresh entry with new TTL
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
koala73
added a commit
that referenced
this pull request
Mar 1, 2026
- Replace manual getCachedJson/setCachedJson with cachedFetchJson for intl delays — prevents thundering herd (concurrent misses each firing 93 API calls independently) - Bump Redis cache TTL from 30min to 2h - Bump frontend polling from 10min to 2h to match server cache - Bump circuit breaker browser cache from 5min to 2h - Bump CDN edge tier from medium (5min) to static (1h) - Bump cache key to v3 to force fresh entry with new TTL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCachedJson/setCachedJsonwithcachedFetchJsonfor intl delays — concurrent cache misses now coalesce into a single fetch instead of each independently firing 93 API callsmedium(5mins-maxage) →static(1hs-maxage)intl:v2→intl:v3to force fresh entryRoot cause
Each cache miss triggered 93 individual AviationStack API calls (one per non-US airport). With 10-min frontend polling, 5-min circuit breaker, 5-min CDN edge cache, and thundering herd vulnerability — multiple concurrent users could fire thousands of calls/day.
Impact
Supersedes #617 (which only bumped Redis TTL).
Test plan
tsc --noEmitpasses