fix(oref): show OREF history count in badge and stop swallowing fetch errors#648
Merged
fix(oref): show OREF history count in badge and stop swallowing fetch errors#648
Conversation
Badge always showed 0 when no active sirens, even with 500+ history records from the relay. Three fixes: - Badge count falls back to historyCount24h when no active alerts - History fetch errors are now logged instead of silently swallowed - Shows immediate history summary while full wave data loads
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
koala73
changed the title
koala73
added a commit
that referenced
this pull request
Mar 1, 2026
…rs (#648) Badge always showed 0 when no active sirens, even with 500+ history records from the relay. Three fixes: - Badge count falls back to historyCount24h when no active alerts - History fetch errors are now logged instead of silently swallowed - Shows immediate history summary while full wave data loads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
historyCount24hwhen no active sirens (was always 0).catch(() => {})Context
Railway relay bootstraps 500+ OREF history records, but the panel badge showed
0and no history section rendered. Root cause:setCount(this.alerts.length)only counted active alerts, andloadHistory()errors were silently eaten.Test plan
historyCount24hwhen no active sirens[OrefSirensPanel] History fetch failedif history endpoint is down