fix(pwa): stop auto-reload on service worker update#686
Merged
Conversation
virtual:pwa-register with registerType 'autoUpdate' installs a controllerchange listener that calls window.location.reload() whenever a new SW takes control. Combined with skipWaiting + clientsClaim, every deployment triggered a visible full-page reload on first visit. Replace with manual navigator.serviceWorker.register() that preserves all PWA functionality (precaching, offline, hourly update checks) without the forced reload. chunk-reload.ts still handles stale chunk 404s.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
virtual:pwa-registerwith manualnavigator.serviceWorker.register()to eliminate the forced page reload triggered by the PWA auto-updatecontrollerchangelistenerchunk-reload.tsguard still handles stale chunk 404s as safety netContext
With
registerType: 'autoUpdate'+skipWaiting+clientsClaim, every deployment caused a visible full-page reload on first visit — the new SW installs, activates, claims the page, andvirtual:pwa-register'scontrollerchangehandler callswindow.location.reload().Test plan