fix(oref): sanitize Hebrew Unicode for reliable translation#694
Merged
Conversation
…tion OREF API embeds invisible RTL/LTR marks and zero-width chars in Hebrew strings, breaking exact key lookup in both STATIC_TRANSLATIONS and OREF_LOCATIONS maps. Also normalizes en-dash variants to ASCII hyphen and adds bare city entries (Beer Sheva, Ashdod, Ashkelon, Sderot).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AaronCorkyj
pushed a commit
to AaronCorkyj/worldmonitor
that referenced
this pull request
Mar 1, 2026
…tion (koala73#694) OREF API embeds invisible RTL/LTR marks and zero-width chars in Hebrew strings, breaking exact key lookup in both STATIC_TRANSLATIONS and OREF_LOCATIONS maps. Also normalizes en-dash variants to ASCII hyphen and adds bare city entries (Beer Sheva, Ashdod, Ashkelon, Sderot).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitizeHebrew()to strip invisible Unicode control chars (RTL/LTR marks, zero-width chars) and normalize dash variants that OREF API embeds in Hebrew stringstranslateLocation()(location map lookup) andstaticTranslate()(category name lookup) before matching against translation mapsTest plan
npx tsc --noEmit— cleannpx vite build— successnode --test tests/oref-locations.test.mjs— 8/8 pass