fix: disable map repetition & use English-only labels#92
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SebastienMelki
added
area: map
Switch from CARTO dark_all raster tiles (which showed continent names in local languages like 亚洲, AFRIKA, أفريقيا) to CARTO Dark Matter vector style with English labels. Set renderWorldCopies: false to prevent horizontal map duplication. Use interleaved deck.gl overlay so basemap labels render above data layers. Closes #81 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SebastienMelki
force-pushed
the
fix/map-no-repeat-no-labels
branch
from
c8d6585 to
834ab3e
Compare
Owner
|
Theme switch breaks country hover/highlight overlays Suggested fix
|
Owner
|
Done
…On Tue, 17 Feb 2026 at 16:31, Sebastien Melki ***@***.***> wrote:
*SebastienMelki* left a comment (koala73/worldmonitor#92)
<#92 (comment)>
@koala73 <https://github.com/koala73> Small ask — could you enable GitHub
Discussions on the repo? We're getting feature proposals (like #78
<#78>) that would fit
better as discussions rather than issues. Would help keep the issue tracker
focused on actionable bugs/features.
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHTJ5G2ZUWG73KHCMWNEYD4MMC33AVCNFSM6AAAAACVMW4O52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMJUGQ2TMMZZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
setStyle() replaces all map sources/layers. Country boundaries were only loaded once (guarded by countryGeoJsonLoaded) so they vanished after theme toggle with no way to re-add them. - Reset countryGeoJsonLoaded in switchBasemap so loadCountryBoundaries can re-run after the new style loads - Listen for style.load before re-adding country source/layers - Guard setupCountryHover with countryHoverSetup flag to prevent duplicate mousemove/mouseout listeners on re-load - Apply theme-correct paint values after layer creation
Store the active highlighted ISO code so it can be re-applied after setStyle() rebuilds map layers with empty default filters.
facusturla
pushed a commit
to facusturla/worldmonitor
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dark_allraster tiles to CARTO Dark Matter vector style — labels now render in English instead of local scripts (亚洲, AFRIKA, أفريقيا, AMÉRICA DO SUL)renderWorldCopies: falseto prevent the map from repeating horizontallyinterleaved: trueso basemap labels render above data layersCloses #81
Test plan
🤖 Generated with Claude Code