Remove trailing slash from request to retrieve all tags#230
Merged
koalalorenzo merged 2 commits intokoalalorenzo:masterfrom Nov 29, 2017
Merged
Remove trailing slash from request to retrieve all tags#230koalalorenzo merged 2 commits intokoalalorenzo:masterfrom
koalalorenzo merged 2 commits intokoalalorenzo:masterfrom
Conversation
…nger appears to be compatible with the API
Owner
|
I am not sure why the tests are failing, could you update them in case those keep failing? |
Contributor
Author
|
It looks like the request being made in the test to validate the library's output had the same problem with the trailing slash. I've pushed an update to the test as well now. |
koalalorenzo
approved these changes
Nov 29, 2017
mioi
pushed a commit
to mioi/python-digitalocean
that referenced
this pull request
Oct 11, 2018
This was fixed for the `get_all_tags()` function in PR koalalorenzo#230, but was not fixed for the function to create new tags. creating new tags is resulting in a `NotFoundError` exception. This should fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls to
Manager.get_all_tags()started throwing aNotFoundErrorfor me.I turned on logging and confirmed that the call to
https://api.digitalocean.com/v2/tags/?per_page=200is returning a 404. I validated this by directly submitting the request:Removing the trailing slash from the request returned the expected response object both in curl and through the library.
This is also consistent with the API documentation: