Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule is very similar to SC2292 / require-double-brackets: https://www.shellcheck.net/wiki/SC2292
Which is an optional rule that enforces "[[" over "[" in Bash.
This new rule in this PR is SC2337 / require-double-equals.
It enforces "==" over "=". (It's an optional check in the same way that SC2292 is optional.)
Double equals is preferable because the code becomes more easy to read - in programming, a single equals usually means assignment and a double equals usually means equality comparison.
Let me know if anything else is needed.