-
Notifications
You must be signed in to change notification settings - Fork 3
Katalon integration #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Katalon integration #379
Conversation
WalkthroughAdded a new Katalon integration guide and navigation entry; extracted Appium server URL examples into a shared partial and updated Tosca docs to include it; inserted an AsciiDoc anchor before the "Favorite the device" section in device management docs. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant KatalonStudio as Katalon Studio
participant KobitonPlugin as Kobiton Plugin
participant KobitonPortal as Kobiton Portal
User->>KatalonStudio: Install/enable Kobiton plugin
KatalonStudio->>KobitonPlugin: Prompt for credentials
User->>KobitonPlugin: Provide credentials
KobitonPlugin->>KobitonPortal: Verify connection (auth)
User->>KobitonPortal: Mark device favorite / upload app
User->>KatalonStudio: Configure test (capabilities/app)
KatalonStudio->>KobitonPortal: Request session (using capabilities)
KobitonPortal-->>KatalonStudio: Session established / device allocated
KatalonStudio->>KobitonPortal: Execute test
KobitonPortal-->>KatalonStudio: Return results
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
docs/modules/integrations/pages/tosca/tosca-integration.adoc (1)
38-40: Duplicate Appium-server bullets were left behind.
Lines 38-40 still hard-code the three server URLs, but you now pull the same text from the new partial at Line 148. Keeping both produces redundant content and maintenance risk.-** For Cloud/Hybrid environments, enter `\https://api.kobiton.com/wd/hub`. -** For Cloud/Hybrid environments with custom domain, enter `\https://api-<custom-domain>.kobiton.com/wd/hub`. -** For Standalone/On-Prem environments, enter `[http|https]://[dell_ip_or_hostname]/wd/hub`.
🧹 Nitpick comments (2)
docs/modules/integrations/partials/appium-server-url.adoc (1)
1-3: Verify the list-level used for the partial.
The lines begin with**, which renders as a second-level list item.
This works only when the partial is included inside a first-level list (e.g.* For Server address:). If any guide ever includes the partial at top level, the bullets will be indented unexpectedly.Consider guarding against misuse by:
-** For Cloud/Hybrid environments, enter … +* For Cloud/Hybrid environments, enter …or adding a short header comment in the partial explaining that it must be nested.
docs/modules/integrations/pages/katalon/katalon-integration.adoc (1)
156-158: Quote/parenthesis mismatch in the example line.The sentence currently renders:
Replace it with""or". Example:"kobiton-store:v1"…`The opening back-tick before
<direct-download-url>is not closed, and the period sits inside the back-ticks. Readers will see malformed inline code.Suggested tightening:
-Replace it with `"<app-version-id>"` or `"<direct-download-url>. Example: `"kobiton-store:v1"` or `"https://drive.example.com/sample.apk"` +Replace it with `"<app-version-id>"` or `"<direct-download-url>"`. +Example: `kobiton-store:v1` or `https://drive.example.com/sample.apk`
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (20)
docs/modules/integrations/images/katalon-device-selection-dropdown-kobiton-device.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-device-selection-kobiton.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-menu-mac-open-settings.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-mobile-config-start-application-file.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-mobile-config-start-application-id.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-plugin-installed-kobiton-integration.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-plugin-reload-from-user-profile.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-preferences-access-linux-ubuntu.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-preferences-access-windows.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-preferences-enable-kobiton-integration.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-settings-create-new-project.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-start-application-params-kobiton-app-id.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-start-application-params-local-app-variable.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-test-case-default-view.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-test-case-script-view.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-test-case-start-application-default-value.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-toolbar-run-or-debug-test.pngis excluded by!**/*.pngdocs/modules/integrations/images/katalon-toolbar-start-recording.pngis excluded by!**/*.pngdocs/modules/integrations/images/kobiton-apps-dashboard.pngis excluded by!**/*.pngdocs/modules/integrations/images/kobiton-device-list-favorites.pngis excluded by!**/*.png
📒 Files selected for processing (5)
docs/modules/devices/pages/manage-devices.adoc(1 hunks)docs/modules/integrations/nav.adoc(1 hunks)docs/modules/integrations/pages/katalon/katalon-integration.adoc(1 hunks)docs/modules/integrations/pages/tosca/tosca-integration.adoc(1 hunks)docs/modules/integrations/partials/appium-server-url.adoc(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: publish-docs-test
- GitHub Check: Test Build
- GitHub Check: publish-docs-test
🔇 Additional comments (2)
docs/modules/integrations/nav.adoc (1)
41-41: Entry looks good.
Navigation item added in correct alphabetical position and matches file path.docs/modules/integrations/pages/katalon/katalon-integration.adoc (1)
71-71: Use the same include path everywhere.Katalon guide references
integrations:partial$appium-server-url.adoc, differing from Tosca page. Standardising avoids broken links if module prefixes change.Confirm which variant Antora resolves in your playbook and align all includes accordingly.
erincbailey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes
docs/modules/integrations/pages/katalon/katalon-integration.adoc
Outdated
Show resolved
Hide resolved
|
Merged after addressing minor comments. |
Summary
Related PRs, issues, or features (optional)
Metadata
PR contributor checklist
My PR follows the Kobiton Docs contributor guidelines, meaning:
nav.adocfile.en-us) from my URLs.Summary by CodeRabbit
New Features
Documentation