Skip to content

fix(ro): correct checksum alignment for 10-digit CUI numbers#150

Merged
koblas merged 2 commits intomainfrom
xuser-dkoblas-fix-ro
Mar 22, 2026
Merged

fix(ro): correct checksum alignment for 10-digit CUI numbers#150
koblas merged 2 commits intomainfrom
xuser-dkoblas-fix-ro

Conversation

@koblas
Copy link
Owner

@koblas koblas commented Mar 22, 2026

No description provided.

@koblas koblas merged commit a013854 into main Mar 22, 2026
2 checks passed
@koblas koblas deleted the xuser-dkoblas-fix-ro branch March 22, 2026 08:22
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with the checksum validation for Romanian CUI numbers, specifically for 10-digit numbers. The changes ensure that the checksum is calculated correctly by padding the input to the appropriate length and adjusting the validation logic. Additionally, the pull request includes updated dependencies and new test cases to ensure the correctness of the changes.

Highlights

  • Checksum Alignment: Corrected the checksum alignment for 10-digit CUI numbers by padding the input to 10 digits instead of 9.
  • Validation Logic: Updated the validation logic to use (sum % 11) % 10 for checksum verification, ensuring accurate validation of CUI numbers.
  • Test Cases: Added new test cases to validate 8-digit CUI numbers, including valid and invalid checksum scenarios after padding.
  • Dependency Overrides: Added an override for the minimatch dependency to version 9.0.7 in package.json.
  • Package Updates: Updated the package version from 1.11.7 to 1.11.8 and removed unnecessary dependencies in package-lock.json.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the stdnum package to version 1.11.8, which includes significant dependency cleanup and version adjustments within package-lock.json, and adds a minimatch override in package.json. Additionally, it addresses a bug in the Romanian CUI (VAT ID) validation logic by modifying the padding length for checksum calculation from 9 to 10 digits and correcting the checksum modulus operation from sum % 10 to (sum % 11) % 10. New test cases have been added to verify these updated validation rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant