Skip to content

support sbt plugin #235

Merged
kobylynskyi merged 59 commits intokobylynskyi:masterfrom
jxnu-liguobin:master
Jul 23, 2020
Merged

support sbt plugin #235
kobylynskyi merged 59 commits intokobylynskyi:masterfrom
jxnu-liguobin:master

Conversation

@jxnu-liguobin
Copy link
Copy Markdown
Collaborator

@jxnu-liguobin jxnu-liguobin commented Jul 17, 2020

different points and this is just a preview of the draft pull request, some bugs if found, i will fix.

  1. option packageName rename to generatePackageName because it is conflict with SBT key
  2. add task for Validate at sbt terminal use it like graphqlSchemaValidate filepath1 filepath2 filepath3, also graphqlCodegenValidate exists for validate graphqlSchemaPaths
  3. use default outputDir src_managed_graphql and default resources directory src/main/resources.
  4. support auto import graphql-java-codegen and validation-api
  5. graphqlCodegen is equals to maven task generate or gradle task graphqlCodegen

Comment thread plugins/sbt/graphql-java-codegen-sbt-plugin/README.md Outdated
Comment thread plugins/sbt/graphql-java-codegen-sbt-plugin/sbt-codegen-exmaple/build.sbt Outdated
@kobylynskyi
Copy link
Copy Markdown
Owner

Thanks for creating the PR.
Could you please also fix sonarcloud config.

Copy link
Copy Markdown
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for setting up the scripted test!

I didn't review very closely and don't have time to work on the sbt plugin anymore since I'm using the gradle plugin now, but it looks okay to me now

Copy link
Copy Markdown
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jxnu-liguobin this looks good for me too.
I would ask you to please the library dependency to 2.4.0 (released today).
And please update the plugin too by adding one more option directiveAnnotationsMapping.
Thanks!

fix example support with v2.4.0 add typename
@jxnu-liguobin
Copy link
Copy Markdown
Collaborator Author

OK, I've updated and fixed the example code with the typename added in 2.4
finally, I adjusted the version to 2.4.1-SNAPSHOT

Copy link
Copy Markdown
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will you release the new version of the plugin (2.4.0)?

@jxnu-liguobin
Copy link
Copy Markdown
Collaborator Author

Looks good! Will you release the new version of the plugin (2.4.0)?

Yes I have did at 7-23 21:39 UTC+8

@kobylynskyi
Copy link
Copy Markdown
Owner

I this ready to be merged? If yes, then please mark the PR as "Ready for review".

@jxnu-liguobin jxnu-liguobin marked this pull request as ready for review July 23, 2020 15:27
@jxnu-liguobin
Copy link
Copy Markdown
Collaborator Author

I this ready to be merged? If yes, then please mark the PR as "Ready for review".

yes

@kobylynskyi kobylynskyi merged commit 56b9dfe into kobylynskyi:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants