support sbt plugin #235
support sbt plugin #235kobylynskyi merged 59 commits intokobylynskyi:masterfrom jxnu-liguobin:master
Conversation
|
Thanks for creating the PR. |
… the standard way
� Conflicts: � .github/workflows/github.yml
2. update client example 3. update version to 2.3.0
merge from master
benmccann
left a comment
There was a problem hiding this comment.
thanks for setting up the scripted test!
I didn't review very closely and don't have time to work on the sbt plugin anymore since I'm using the gradle plugin now, but it looks okay to me now
kobylynskyi
left a comment
There was a problem hiding this comment.
@jxnu-liguobin this looks good for me too.
I would ask you to please the library dependency to 2.4.0 (released today).
And please update the plugin too by adding one more option directiveAnnotationsMapping.
Thanks!
merge from master
fix example support with v2.4.0 add typename
|
OK, I've updated and fixed the example code with the typename added in 2.4 |
kobylynskyi
left a comment
There was a problem hiding this comment.
Looks good! Will you release the new version of the plugin (2.4.0)?
Yes I have did at 7-23 21:39 UTC+8 |
|
I this ready to be merged? If yes, then please mark the PR as "Ready for review". |
yes |
different points and this is just a preview of the draft pull request, some bugs if found, i will fix.
packageNamerename togeneratePackageNamebecause it is conflict with SBT keygraphqlSchemaValidate filepath1 filepath2 filepath3, alsographqlCodegenValidateexists for validategraphqlSchemaPathssrc_managed_graphqland default resources directorysrc/main/resources.graphql-java-codegenandvalidation-apigraphqlCodegenis equals to maven taskgenerateor gradle taskgraphqlCodegen