Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 28, 2020

Bumps mapstruct from 1.3.1.Final to 1.4.0.Final.

Release notes

Sourced from mapstruct's releases.

1.4.0.Final

For full upgrade instructions please read the release notes for the previous 1.4 releases:

Bugs

  • Possible regression: Wrong mapper code generation when using Builder (#2195)
  • Qualifier is ignored in case of name based mapping when there are multiple source parameters (#2125)
  • Invalid code generated for enum mapping when field name starts with underscore '_' and continues with digits (#2197)

1.4.0.CR1

Features

  • Support custom unexpected enum constant exception for Value (Enum) Mapping (#2169)

Enhancements

  • Use short names instead of FQN's in error messages (PR #2166)
  • Redundant exception wrapping in nested generated method (#2174)
  • StackOverflow caused by recursive uses declaration (#2185) - There is now a compile warning instead of a stack overflow error

Bug fixes

  • Missing import in generated mapping class when using generic mapper interface (#2170)
  • Mapping to generic class via constructor does not work (#2177)
  • Parameter no longer recognised in 1.4 when not explicitly mentioned (#2164)

Documentation

  • Add @since 1.4 to new interfaces (#2167)
  • Fix typos

1.4.0.Beta3

Enhancements

  • Improve the error message when using @Qualifier in 2 step mapping methods (#2135)
  • Strip leading underscore when in local variable names (#2142)
  • Allow @Default to overrule potentially existing parameterless default constructor. (#2150) - With this we actually changed the rules for selection a constructor. Now the following is done:
    • Constructor annotated with @Default (from any package) has highest precedence

... (truncated)

Commits
  • 9973b92 [maven-release-plugin] prepare release 1.4.0.Final
  • 060f17e #2125 Report an error when source parameter could not be determined from targ...
  • e17e744 Dependency upgrades
  • 52ab22b #2197 Strip leading underscores and digits when sanitizing identifier name
  • 427f502 #2195 @Beanmapping#resultType should be used to construct return type also if...
  • 8b22654 [maven-release-plugin] prepare for next development iteration
  • c962962 [maven-release-plugin] prepare release 1.4.0.CR1
  • e0eb0f6 #2164 parameter matching should be done based on name when source name is abs...
  • 7dcbef3 #2169 Add support for defining a custom unexpected value mapping exception
  • a9451b1 #2185 Fix StackOverflow error when recursive use of mapper in Mapper#uses
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @kobylynskyi.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 28, 2020
@dependabot dependabot bot requested a review from kobylynskyi September 28, 2020 05:50
kobylynskyi
kobylynskyi previously approved these changes Sep 30, 2020
Copy link
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot squash and merge

Bumps [mapstruct](https://github.com/mapstruct/mapstruct) from 1.3.1.Final to 1.4.0.Final.
- [Release notes](https://github.com/mapstruct/mapstruct/releases)
- [Commits](mapstruct/mapstruct@1.3.1.Final...1.4.0.Final)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/plugins/gradle/example-client/org.mapstruct-mapstruct-1.4.0.Final branch from 7a1b0f9 to 1b7957f Compare September 30, 2020 21:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 30, 2020

Dependabot tried to merge this PR, but received the following error from GitHub:

At least 1 approving review is required by reviewers with write access.

Copy link
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot squash and merge

@dependabot dependabot bot merged commit cc91244 into master Sep 30, 2020
@dependabot dependabot bot deleted the dependabot/gradle/plugins/gradle/example-client/org.mapstruct-mapstruct-1.4.0.Final branch September 30, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants