Skip to content

feat: add TUI progress bar for mainframe xpublic zip download#2

Merged
derozgurg merged 12 commits intomasterfrom
feature/progress-bar-for-mainframe-xpublic-zip
Jun 27, 2025
Merged

feat: add TUI progress bar for mainframe xpublic zip download#2
derozgurg merged 12 commits intomasterfrom
feature/progress-bar-for-mainframe-xpublic-zip

Conversation

@asimtahir-karakus-kd
Copy link
Copy Markdown
Collaborator

@asimtahir-karakus-kd asimtahir-karakus-kd commented Jun 27, 2025

The purpose of this PR is to show the developer the progress of the download of the mainframe xpublic zip

Progress bar screenshot

This comment was marked as outdated.

@asimtahir-karakus-kd asimtahir-karakus-kd force-pushed the feature/progress-bar-for-mainframe-xpublic-zip branch from ed71c86 to 177fe53 Compare June 27, 2025 13:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a terminal progress bar for the MainFrame Xpublic ZIP download and updates development dependencies.

  • Updates sass version and removes the fibers dependency in package.json.
  • Adds download progress bar logic and improved error handling in streempublic.js.

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.

File Description
package.json Removed fibers and tightened sass version range.
lib/commands/serve/streempublic.js Implemented a TUI progress bar, added error listeners, and refined console output.
Comments suppressed due to low confidence (1)

package.json:114

  • The fibers dependency was removed—ensure no code paths still rely on it, as this could break existing synchronous logic.
  "devDependencies": {

Comment thread lib/commands/serve/streempublic.js Outdated
Comment thread lib/commands/serve/streempublic.js Outdated
Comment thread lib/commands/serve/streempublic.js Outdated
@asimtahir-karakus-kd asimtahir-karakus-kd force-pushed the feature/progress-bar-for-mainframe-xpublic-zip branch from a6635f7 to ceb05f4 Compare June 27, 2025 14:09
@asimtahir-karakus-kd asimtahir-karakus-kd force-pushed the feature/progress-bar-for-mainframe-xpublic-zip branch from 0035064 to 5fdcda0 Compare June 27, 2025 14:13
@derozgurg derozgurg merged commit 5c5fafa into master Jun 27, 2025
@asimtahir-karakus-kd asimtahir-karakus-kd deleted the feature/progress-bar-for-mainframe-xpublic-zip branch June 30, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants