Address PR #251 review feedback: fix imports, memory leaks, accessibility, and add tests#252
Merged
kocheck merged 4 commits intoclaude/refactor-modular-architecture-GUfVCfrom Feb 10, 2026
Conversation
…essibility
- Fix DoorBlocking.test.ts import paths (../types → ../../types)
- Revoke existing object URL before creating new one in useCanvasDrop
- Use asset pipeline (processImage) instead of base64 for cropped images
- Improve CommandPalette keyboard accessibility (tabIndex={0} + aria-activedescendant)
- Gate arrow key movement in World View in CanvasAccessibility
Addresses feedback from PR #251 review thread.
Co-authored-by: kocheck <7952000+kocheck@users.noreply.github.com>
- Test drag over behavior (World View blocking) - Test library token drop - Test generic token drop - Test file drop and object URL creation - Test object URL revocation on multiple drops (memory leak prevention) - Test crop confirm with asset pipeline integration - Test crop confirm error handling - Test crop cancel cleanup 12 tests covering all main branches and edge cases. Addresses Issue #6 from PR review thread. Co-authored-by: kocheck <7952000+kocheck@users.noreply.github.com>
Wrap handleCropConfirm with void operator to satisfy TypeScript linter when passing async function to prop expecting void return. Co-authored-by: kocheck <7952000+kocheck@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add modular architecture refactor game plan
Address PR #251 review feedback: fix imports, memory leaks, accessibility, and add tests
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 6 review comments from PR #251 focusing on correctness (import paths, memory management), performance (asset pipeline), and accessibility (keyboard navigation).
Import Path Fix
../types/*→../../types/*to resolve tosrc/types/Memory Leak Prevention
Asset Pipeline Integration
Replaced base64 conversion with asset processing pipeline for cropped images:
Reduces memory usage, store size, and IPC sync payload.
Accessibility Improvements
tabIndex={0}+aria-activedescendantpattern for keyboard navigationTest Coverage
Added
useCanvasDrop.test.tswith 12 tests covering:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.