Skip to content

users api debug and edge case fix#2957

Merged
AllenShen merged 1 commit intokoderover:mainfrom
jamsman94:bugfix/user
Aug 11, 2023
Merged

users api debug and edge case fix#2957
AllenShen merged 1 commit intokoderover:mainfrom
jamsman94:bugfix/user

Conversation

@jamsman94
Copy link
Contributor

@jamsman94 jamsman94 commented Aug 11, 2023

What this PR does / Why we need it:

🤖 Generated by Copilot at a7e1356

This pull request enhances the collaboration environment feature and the user search API in Zadig. It allows non-admin users to list products in collaboration environments, and adds pagination support to the user search API.

What is changed and how it works?

🤖 Generated by Copilot at a7e1356

  • Support pagination in user search API by adding PerPage and Page fields to SearchArgs struct (link)
  • Allow users with collaboration environment permission to list products in those environments by moving the permission check outside of the project admin check (link)

Does this PR introduce a user-facing change?

  • API change
  • database schema change
  • upgrade assistant change
  • change in non-functional attributes such as efficiency or availability
  • fix of a previous issue

Signed-off-by: Min Min <minmin@koderover.com>
@AllenShen AllenShen merged commit 72478c8 into koderover:main Aug 11, 2023
AllenShen pushed a commit that referenced this pull request Aug 11, 2023
* fix panic bug & minor permission problem

Signed-off-by: Min Min <minmin@koderover.com>

* users api debug and edge case fix

Signed-off-by: Min Min <minmin@koderover.com>

---------

Signed-off-by: Min Min <minmin@koderover.com>
Co-authored-by: Min Min <minmin@koderover.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants