Skip to content

feat: add release plan collaboration and versioned diffs#4689

Open
huanghongbo-hhb wants to merge 40 commits into
koderover:mainfrom
huanghongbo-hhb:feat/release-plan-collaboration-v1
Open

feat: add release plan collaboration and versioned diffs#4689
huanghongbo-hhb wants to merge 40 commits into
koderover:mainfrom
huanghongbo-hhb:feat/release-plan-collaboration-v1

Conversation

@huanghongbo-hhb

@huanghongbo-hhb huanghongbo-hhb commented May 19, 2026 •
edited by landylee007
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add release plan collaboration state and section-based versioned diffs
  • optimize workflow snapshot building and suppress false diffs for unchanged saves

Main Changes

  • expose structured diff specs for metadata, approval, and workflow jobs so log details can render stable section-level changes
  • add Redis-backed collaboration sessions and editor snapshot/ws APIs for release plan editing hints
  • stabilize workflow job snapshots with targeted filtering, cache reuse, and ordering to reduce noisy no-op saves
  • normalize rich-text description comparison to ignore serializer-only HTML differences while keeping real text/structure changes

Risk / Compatibility

  • existing save request shape stays unchanged; rich-text formatting-only saves no longer create false config logs
  • low risk: changes are scoped to release plan snapshot, diff, and collaboration logic

Test

  • UAT verified collaboration state, versioned diff rendering, and unchanged-save behavior
  • GOCACHE=/Users/koderover/Workspace/zadig/.cache/go-build go test ./pkg/microservice/aslan/core/release_plan/service -run 'TestHasReleasePlanSnapshotChanges(...)' -count=1

Contact

This change is Reviewable

@huanghongbo-hhb huanghongbo-hhb force-pushed the feat/release-plan-collaboration-v1 branch 2 times, most recently from 48a0028 to 40fd377 Compare May 22, 2026 06:24
@huanghongbo-hhb huanghongbo-hhb force-pushed the feat/release-plan-collaboration-v1 branch from e5bca43 to be82dce Compare June 9, 2026 08:21
@huanghongbo-hhb huanghongbo-hhb force-pushed the feat/release-plan-collaboration-v1 branch from a1284a9 to c4975b6 Compare June 11, 2026 08:50
@huanghongbo-hhb huanghongbo-hhb mentioned this pull request Jun 25, 2026
Open
huanghongbo-hhb added a commit to huanghongbo-hhb/zadig that referenced this pull request Jun 25, 2026
@huanghongbo-hhb
feat: port release plan collaboration and versioned diffs to 4.3.0
33fa564 
Cherry-pick of koderover#4689 onto release-4.3.0. Excludes the job_restart.go
FetchSelectedWorkloads tweak (DaemonSet merge collateral, N/A on 4.3.0).

Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
PetrusZ
PetrusZ reviewed Jun 25, 2026
View reviewed changes
Comment thread pkg/microservice/aslan/core/common/service/workflowcontroller/jobcontroller/job_restart.go Outdated
@huanghongbo-hhb
feat: add release plan collaboration and versioned diffs
cde3380 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
chore: remove release plan RFC from PR
ac78461 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
refactor: simplify release plan version semantics
ac6efbe 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
chore: extend release plan collaboration ttl
4f71191 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: align release plan approval logs in watcher
db5a8c8 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: harden release plan collaboration flows
ebbde9f 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
feat: support ordered release plan diffs
01e61c6 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
chore: remove diff tests from pr
950e019 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
refactor: simplify release plan diff labels
8d3ec5d 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix release plan collaboration cleanup and diff order
c0bd8a9 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: improve release plan target order labels
dd011f9 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: refine release plan version diff snapshots
4812543 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: polish release plan collaboration follow-ups
6ab9efd 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: harden release plan collaboration lifecycle
9739584 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
chore: remove release plan test files from pr
551e9a9 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: preserve release plan initial diff baseline
fac3036 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: align release plan workflow diff snapshot
57fa175 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: enrich release plan workflow snapshot
90b0220 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: log workflow snapshot recover events
8b7f058 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: keep workflow skipped flag in release plan snapshot
f1a5a99 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: backfill incomplete workflow diff base snapshot
9122345 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
feat: expose approval snapshot diff display mode
ccdf6d0 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: preserve rich text release plan diff values
38f0eac 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: skip empty release plan logs
5186748 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: cap diff depth and batch collab reads
cee6350 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
refactor: align release plan metadata section keys
928c28c 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: skip empty release plan snapshot changes
40b6860 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: ignore derived approval users in release plan logs
fcbb3be 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: refine release plan metadata diff display
1ad1771 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: stabilize release plan workflow diff snapshots
6ccffce 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: compat legacy release plan workflow lookup fields
8a6be57 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: normalize legacy release plan workflow specs
167170e 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
perf: optimize release plan workflow snapshots
65bf542 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: normalize release plan rich text diff
97126c0 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: isolate release plan workflow snapshot cache
746117b 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: avoid no-op release plan collaboration updates
408c443 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: include release jobs in initial release plan diff
f99f5eb 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: skip empty initial release plan diffs
c8d136c 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: treat empty release job rich text as unchanged
4a46128 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: retain initial release job diffs
698c3d1 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb huanghongbo-hhb force-pushed the feat/release-plan-collaboration-v1 branch from a14261b to 698c3d1 Compare June 25, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cynthia-0203 Cynthia-0203 Awaiting requested review from Cynthia-0203
@leebrouse leebrouse Awaiting requested review from leebrouse
1 more reviewer
@PetrusZ PetrusZ PetrusZ left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

common service/aslan

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huanghongbo-hhb @PetrusZ