Backoff doesn't work

[fatih]

http://take.ms/QLsXH

The Retry() methods get called, but the interval duration coming from the backoff is wrong as seen in the screenshot above.

https://github.com/koding/kite/blob/master/client.go#L160

[cenkalti]

@fatih The commit should fix the bug, but I did not test it.

[fatih]

You close it before you test it? :) That's good hehe :) That fixed it, thanks for the quick fix.

Btw, what was the reason for declaring the backoff instance globally? https://github.com/koding/kite/blob/master/client.go#L23

[cenkalti]

Sorry, it was very trivial that's why I did not test it :)

forever is the default value for Client.backoff. A new copy is made when a Client is created with NewClient See: https://github.com/koding/kite/blob/master/client.go#L112
It does not have to be global though.

A better approach would be change the type of redialBackOff from backoff.ExponentialBackoff to backoff.Backoff interface to allow user to assign a custom backoff algorithm.