Upgrade to PHP 8.4

[hcsagan]

Tests did not fail at all, but there were some areas that could be improved, so I just did that.

[thomasnordahl-dk]

I appreciate the boyscout rule, but adding return types and the default makes this backwards incompatible. Let's keep it light for the PHP 8.4 upgrade, and not do major versions here.

[thomasnordahl-dk]

Suggested change

	private bool $is_new = false
	private bool $is_new

Adding it as a default is backwards incompatible

[hcsagan]

It already has a default in line 40, so it doesn't have a difference.

Besides that, I am not sure how far backwards compatible we are talking about. composer.json says minimum php 8.0 already and everything passes in 8.0 environment.

[thomasnordahl-dk]

It wasn't default in the constructor signature, which is the breaking part :-)

original: public function __construct(string $client_session_id, array $data, bool $is_new)

[thomasnordahl-dk]

Because it is public, we should stay strict - we can cut corners on private repositories because we know how we extend and when a b\c break is an issue or not.

[mifich]

This is also a breaking change :)

[thomasnordahl-dk]

I checked in 3v4l.org and I think the void return type isn't an issue on extension. This works fine:

<?php

class Foo
{
    public function myMethod()
    {
        echo 'hello';
    }
}

class Bar extends Foo
{
    public function myMethod(): void
    {
        echo 'hola';
    }
}

new Bar()->myMethod();

[hcsagan]

It is not internally, because SessionData has the return types as well. In your example Foo should be an interface and it should have the return type, not Bar. In that case it throws a fatal error:

Fatal error: Declaration of SessionData::clear() must be compatible with Session::clear(): void in /in/JcVqe on line 8

So, the return types should be removed from the interface and SessionData if we want to keep them compatible.

[thomasnordahl-dk]

👍