fix(frontend): Fix the base URL supplied to the frontend#1706
fix(frontend): Fix the base URL supplied to the frontend#1706phanan merged 2 commits intokoel:masterfrom kondratovbr:master
Conversation
PR Summary
|
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1706 +/- ##
============================================
- Coverage 83.99% 83.94% -0.05%
Complexity 643 643
============================================
Files 143 143
Lines 1737 1738 +1
============================================
Hits 1459 1459
- Misses 278 279 +1
☔ View full report in Codecov by Sentry. |
|
Thanks! |
|
Reverted, as this caused #1732. |
I've encountered an issue when running behind a reverse proxy. Proxy terminates SSL correctly and provides correct
X-Forwardedheaders, but URLs generated for the frontend aren'thttps, so it tries to call the API viahttpwhich browsers explicitly forbid and throw an error along the lines of...was not allowed to display insecure content from http://...This PR fixes the
BASE_URLexplicitly used in Vue and the URL in<base>tag which may be used implicitly.Now the "non-working"
APP_URLENV value actually does something.