Fix keyboard reappearing when navigating to Queue#121
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe now-playing screen's queue navigation handler now explicitly clears any active input focus via Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
When the search field has focus and the user opens NowPlayingScreen then taps the queue icon, the keyboard reappears because Flutter restores focus to the search field when pushing via the root navigator. Fix by explicitly unfocusing before the navigation.
356dc00 to
cf841d6
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the search field has focus and the user opens the Now Playing sheet, the keyboard hides correctly. However, tapping the queue icon (
CupertinoIcons.list_number) causes the keyboard to reappear becauseNavigator.pushNamedvia the root navigator triggers Flutter's focus restoration on the underlying search field.Fix: call
FocusManager.instance.primaryFocus?.unfocus()before navigating.Test plan
Summary by CodeRabbit