Add Hero animation and swipe-to-dismiss for Now Playing#122
Conversation
Replace showModalBottomSheet with a custom PageRoute that supports Hero animations on the album thumbnail between MiniPlayer and NowPlayingScreen. Add swipe-down-to-dismiss gesture, drag handle, and platform-aware rounded corners (iOS only, matching device radius). Also improve MiniPlayer progress bar precision (milliseconds instead of seconds) and clamp to prevent overflow.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe changes convert the Now Playing screen from a modal bottom sheet presentation to a full-screen route with custom slide-up transition and drag-to-dismiss capability. A new page route class manages the transition animation, while the screen itself implements gesture-driven dismissal with visual feedback via a drag handle and animated offset. Changes
Poem
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
showModalBottomSheetwith a customPageRoute(NowPlayingPageRoute) that slides up witheaseOutCubiccurve, enabling Hero animations on the album thumbnail between MiniPlayer and NowPlayingScreenMaterial(type: transparency)to maintain text stylingTest plan
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes